Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed: rename PLAYLIST namespace to KODI::PLAYLIST #25196

Merged
merged 1 commit into from May 12, 2024

Conversation

notspiff
Copy link
Contributor

Description

Move PLAYLIST namespace under KODI namespace

Motivation and context

More consistent with game, video, ..

How has this been tested?

It builds.

What is the effect on users?

None

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@notspiff notspiff added Type: Improvement non-breaking change which improves existing functionality v22 "P" labels May 11, 2024
@notspiff notspiff added this to the "P" 22.0 Alpha 1 milestone May 11, 2024
@notspiff notspiff requested a review from DaveTBlake as a code owner May 11, 2024 12:55
@notspiff notspiff force-pushed the move_playlist_namespace_to_kodi branch from 9b3bbe6 to 452432c Compare May 11, 2024 19:27
Copy link
Contributor

@fuzzard fuzzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a scroll through, looked ok at a glance.

@notspiff notspiff merged commit b0d72e8 into xbmc:master May 12, 2024
2 checks passed
@notspiff notspiff deleted the move_playlist_namespace_to_kodi branch May 12, 2024 06:14
@garbear
Copy link
Member

garbear commented May 12, 2024

Nice! I like seeing namespaces predating KODI moved back inside it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement non-breaking change which improves existing functionality v22 "P"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants