Android: Two fixes on the joystick codepath #25179
Draft
+72
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains two fixes for Android quirks on the joystick codepath:
Because only code on the joystick codepath is touched, this PR should have no effect on anything other than joysticks.
Motivation and context
Both fixes are hacks around Android quirks, but with both fixes my PS4 controller works in Kodi.
Because it only affects joysticks, it therefore separates out the remaining "safer" Android fixes from #24604.
I just bought a shiny new PS5 controller, so I'll test that with these fixes too.
How has this been tested?
Tested as part of my RetroPlayer builds since January: https://github.com/garbear/xbmc/releases
Due to the hacky nature of the fixes, more testing is needed. I plan to continue working on joysticks as the other PRs get merged:
What is the effect on users?
Types of change