[PVR][guilib][Estuary] Guide window improvement #25142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksooo
added
Type: Improvement
ksooo
force-pushed
the
estuary-pvr-guide-improvement
branch
from
9e523c0
to
982dc2d
Compare
phunkyfish
approved these changes
May 8, 2024
|
Just a quick note to acknownlege the review request has been seen. I'll try and get to it beofre the weekend. |
|
Looking at the code I don't see any issues, however I've not had time to runtime test which I'd like to do for this PR before Approving. I'm away this weekend but I should have time on Monday if you're not in hurry @ksooo |
jenkins4kodi
added
the
Rebase needed
ksooo
force-pushed
the
estuary-pvr-guide-improvement
branch
from
982dc2d
to
a51ef75
Compare
jenkins4kodi
removed
the
Rebase needed
…nail are available, show both, like we already do in fullscreen OSD.
ksooo
force-pushed
the
estuary-pvr-guide-improvement
branch
from
a51ef75
to
4bd3e88
Compare
|
jenkins build this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: Currently, the Guide window can either display the channel logo or a thumbnail of the programme. If both graphics are available, thumbnail will be preferred. In the fullscreen live TV OSD however, we can show both graphics already:
This PR aligns the guide window content with the OSD contain by adding support for channel logo and programme thumbnail, similar to the OSD.
Before:
After:
In case only channel logo is available, guide window will look like before, channel logo on the left, text area spans to right border of screen.
For this, new GUI info labels were needed:
ListItem.ChannelLogo, VideoPlayer.ChannelLogo, MusicPlayer.ChannelLogo, completing the other channel related labels, (like ListItem.ChannelName and ListItem.ChannelNumberLabel). These labels contain the path of the channel logo of the selected or playing pvr channel.
Runtime-tested on macOS and Android, latest xbmc master.
@jjd-uk could you please have a look at the skin changes?
@phunkyfish please review the code changes.