Update Referee for TBR and TK #455
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
860
to
914
| function updateMaxStakePerLicense(uint256 newAmount) external onlyRole(DEFAULT_ADMIN_ROLE) { | ||
| require(newAmount != 0, "31"); | ||
| uint256 prevAmount = maxStakeAmountPerLicense; | ||
| maxStakeAmountPerLicense = newAmount; | ||
| emit UpdateMaxStakeAmount(prevAmount, newAmount); | ||
| } | ||
|
|
||
| /** | ||
| * @dev Admin update the maximum number of NodeLicense staked in a pool | ||
| * @param newAmount The new maximum amount per NodeLicense | ||
| */ | ||
| function updateMaxKeysPerPool(uint256 newAmount) external onlyRole(DEFAULT_ADMIN_ROLE) { | ||
| require(newAmount != 0, "32"); | ||
| uint256 prevAmount = maxKeysPerPool; | ||
| maxKeysPerPool = newAmount; | ||
| emit UpdateMaxKeysPerPool(prevAmount, newAmount); | ||
| } | ||
|
|
||
| /** | ||
| * @dev Admin update the tier thresholds and the corresponding reward chance boost | ||
| * @param index The index if the tier to update | ||
| * @param newThreshold The new threshold of the tier | ||
| * @param newBoostFactor The new boost factor for the tier | ||
| */ | ||
| function updateStakingTier(uint256 index, uint256 newThreshold, uint256 newBoostFactor) external onlyRole(DEFAULT_ADMIN_ROLE) { | ||
|
|
||
| require(newBoostFactor > 0 && newBoostFactor <= 10000, "33"); | ||
|
|
||
| uint256 lastIndex = stakeAmountTierThresholds.length - 1; | ||
| if (index == 0) { | ||
| require(stakeAmountTierThresholds[1] > newThreshold, "34"); | ||
| } else if (index == lastIndex) { | ||
| require(stakeAmountTierThresholds[lastIndex - 1] < newThreshold, "35"); | ||
| } else { | ||
| require(stakeAmountTierThresholds[index + 1] > newThreshold && stakeAmountTierThresholds[index - 1] < newThreshold, "36"); | ||
| } | ||
|
|
||
| stakeAmountTierThresholds[index] = newThreshold; | ||
| stakeAmountBoostFactors[index] = newBoostFactor; | ||
| } | ||
|
|
||
| /** | ||
| * @dev Admin add a new staking tier to the end of the tier array | ||
| * @param newThreshold The new threshold of the tier | ||
| * @param newBoostFactor The new boost factor for the tier | ||
| */ | ||
| function addStakingTier(uint256 newThreshold, uint256 newBoostFactor) external onlyRole(DEFAULT_ADMIN_ROLE) { | ||
| require(newBoostFactor > 0 && newBoostFactor <= 10000, "37"); | ||
|
|
||
| uint256 lastIndex = stakeAmountTierThresholds.length - 1; | ||
| require(stakeAmountTierThresholds[lastIndex] < newThreshold, "38"); | ||
|
|
||
| stakeAmountTierThresholds.push(newThreshold); | ||
| stakeAmountBoostFactors.push(newBoostFactor); | ||
| } |
There was a problem hiding this comment.
I think we don't need them in version 9 do we ?
There was a problem hiding this comment.
These have been removed, however, I do need the other PR #456 to be reviewed/approved and merged into this branch before converting this from Draft
Comment on lines
1122
to
1005
| // Leaving these functions in the contract for test coverage purposes | ||
| // In the future these can be removed if size becomes an issue | ||
| function toggleAssertionChecking() public { | ||
| isCheckingAssertions = !isCheckingAssertions; | ||
| emit AssertionCheckingToggled(isCheckingAssertions); | ||
| } | ||
|
|
||
| //TEST FUNCTION this is used only for test coverage | ||
| // function setRollupAddress(address newRollupAddress) public { | ||
| // rollupAddress = newRollupAddress; | ||
| // emit RollupAddressChanged(newRollupAddress); | ||
| // } | ||
| } No newline at end of file | ||
| function setRollupAddress(address newRollupAddress) public { | ||
| rollupAddress = newRollupAddress; | ||
| emit RollupAddressChanged(newRollupAddress); | ||
| } | ||
| } |
There was a problem hiding this comment.
These need to be commented out in version 9 too !
There was a problem hiding this comment.
Should we comment these out if we can fit them in the contract size?
We can always still remove in the future, but this would allow us to run the tests without having to manually uncomment every time?
There was a problem hiding this comment.
If we leave them they need restricted access control.
There was a problem hiding this comment.
These have been removed. Once the test case PR is approved, I can merge it into this branch before merging this into develop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Updated current Referee to be compatible with time based rewards.
Testing: tests updated and passing in this PR #456 which should be merged into this branch before this PR is Approved/Merged.