Modernize examples and give them slightly better names #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenstaro
force-pushed
the
modernize-examples
branch
from
7fa26c0 to
b810df3
Compare
xadaemon
requested changes
May 20, 2025
Owner
xadaemon
left a comment
xadaemon
left a comment
There was a problem hiding this comment.
just this one item to fix then good to go
There's no need to prefix examples with example- as they are already in the examples/ dir.
svenstaro
force-pushed
the
modernize-examples
branch
from
b810df3 to
42efd78
Compare
xadaemon
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need to prefix examples with example- as they are already in the examples/ dir.