Skip to content

Commit

Permalink
Remove stats
Browse files Browse the repository at this point in the history
  • Loading branch information
KaptenJansson committed Feb 26, 2019
1 parent 3f6ecee commit 4b649aa
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 13 deletions.
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ browser*
firefox*
node_modules
out
rtstats.js
secrets.json
source-context*.json
temp/*
Expand Down
4 changes: 2 additions & 2 deletions build/build_app_engine_package.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,9 @@ def CopyApprtcSource(src_path, dest_path):
shutil.copy(os.path.join(dirpath, name), dest_path)
elif dirpath.endswith('js'):
for name in files:
# loopback.js and rtstats.js are not compiled by Closure
# loopback.js is not compiled by Closure
# and need to be copied separately.
if name in ['loopback.js', 'rtstats.js']:
if name in ['loopback.js']:
dest_js_path = os.path.join(dest_path, 'js')
if not os.path.exists(dest_js_path):
os.makedirs(dest_js_path)
Expand Down
1 change: 0 additions & 1 deletion src/app_engine/app.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,4 +53,3 @@ env_variables:
# Use appcfg.py --env_variable=ICE_SERVER_API_KEY:KEY \
# in order to replace variables when deploying.
ICE_SERVER_API_KEY: none
WITH_RTSTATS: none
8 changes: 0 additions & 8 deletions src/app_engine/apprtc.py
Original file line number Diff line number Diff line change
Expand Up @@ -252,13 +252,6 @@ def get_room_parameters(request, room_id, client_id, is_initiator):
else:
include_loopback_js = ''

include_rtstats_js = ''
if str(os.environ.get('WITH_RTSTATS')) != 'none' or \
(os.getenv('SERVER_SOFTWARE', '').startswith('Google App Engine/') and \
app_identity.get_application_id() == 'apprtc'):
include_rtstats_js = \
'<script src="/js/rtstats.js"></script><script src="/pako/pako.min.js"></script>'

# TODO(tkchin): We want to provide a ICE request url on the initial get,
# but we don't provide client_id until a join. For now just generate
# a random id, but we should make this better.
Expand Down Expand Up @@ -294,7 +287,6 @@ def get_room_parameters(request, room_id, client_id, is_initiator):
'ice_server_url': ice_server_url,
'ice_server_transports': ice_server_transports,
'include_loopback_js' : include_loopback_js,
'include_rtstats_js' : include_rtstats_js,
'wss_url': wss_url,
'wss_post_url': wss_post_url,
'bypass_join_confirmation': json.dumps(bypass_join_confirmation),
Expand Down
1 change: 0 additions & 1 deletion src/web_app/html/index_template.html
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,6 @@ <h1>AppRTC</h1>
{% if not chromeapp %}
{{ include_loopback_js }}
{% endif %}
{{ include_rtstats_js }}

<script src="/js/apprtc.debug.js"></script>

Expand Down

0 comments on commit 4b649aa

Please sign in to comment.