-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing member used in UserManifest
to define the manifest name.
#1336
Conversation
Added the missing manifest name member when defining the manifest name via the wxt.config.ts manifest option.
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks for the PR, but the |
Yeah, the member is not defined/suggested for the UserManifest type that the
|
I think this is related to Deno. I'll track under #1307. Could you share a reproduction? |
I'll look into this later today that how could I formulate a reproduction of this issue :D |
So I'm gonna close this PR, it's definitely a deno-only thing, and this PR doesn't address the root problem. |
I guess the fix is to simply configure the deno template correctly when the time comes. I don't think there will be anything specific to change in WXT's code. |
Hiya!
I was doing cursed things, like setting this project to run via Deno (successfully mind you!) and I came across a smol oversight in the typings, so I patched it up :)
Happy to take input if you have any!
Br
Permik