-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to move Fonts out of HBIOS area to ROM Bank 3 #486
Open
b1ackmai1er
wants to merge
14
commits into
wwarthen:master
Choose a base branch
from
b1ackmai1er:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f10c8a2
Merge pull request #75 from wwarthen/master
b1ackmai1er b0f44af
Merge pull request #76 from wwarthen/master
b1ackmai1er 1eba93b
Merge pull request #77 from wwarthen/master
b1ackmai1er 52826dd
Merge pull request #78 from wwarthen/master
b1ackmai1er 085285a
Merge pull request #79 from wwarthen/master
b1ackmai1er 25a9ce0
Option to move Fonts out of HBIOS area to ROM Bank 3
b1ackmai1er 2f1da70
Remove debug code
b1ackmai1er f74cec7
CVDU hang on probe issues
b1ackmai1er 658dc92
Logic fix for bank 3 vs hbios access
b1ackmai1er 9e757f8
Add some character colour options to VGA
b1ackmai1er dfd721d
Change to interrupt safe peek
b1ackmai1er 8d0b04b
For appboot, force fonts to be included in HBIOS
b1ackmai1er 99425b8
Typo
b1ackmai1er 245b883
Syncing
b1ackmai1er File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
; Adapted from https://rosettacode.org/wiki/Mandelbrot_set#Z80_Assembly | ||
; by Phillip Summers [email protected] | ||
; | ||
; WBWROM SBV V2 Easteregg | ||
; WBWROM Easteregg | ||
; | ||
; Compute a Mandelbrot set on a simple Z80 computer. | ||
; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
; | ||
;================================================================================================== | ||
; FONTS | ||
;================================================================================================== | ||
; | ||
HB_FONTS_BEG .EQU $ | ||
; | ||
ORG_FONTS .EQU $ | ||
; | ||
MEMECHO "FONTS" | ||
; | ||
#IFDEF USEFONT8X8 | ||
FONT8X8: | ||
|
||
; WE NEVER COMPRESS THE 8X8 FONT AS THERE IS NOT ENOUGH SPACE TO DECOMPRESS THEM AT WARM BOOT | ||
|
||
#IF USELZSA2 & FALSE | ||
#INCLUDE "font8x8c.asm" | ||
#ELSE | ||
#INCLUDE "font8x8u.asm" | ||
#ENDIF | ||
MEMECHO " 8X8" | ||
#ENDIF | ||
; | ||
#IFDEF USEFONT8X11 | ||
FONT8X11: | ||
#IF USELZSA2 | ||
#INCLUDE "font8x11c.asm" | ||
#ELSE | ||
#INCLUDE "font8x11u.asm" | ||
#ENDIF | ||
MEMECHO " 8X11" | ||
#ENDIF | ||
; | ||
#IFDEF USEFONT8X16 | ||
FONT8X16: | ||
#IF USELZSA2 | ||
#INCLUDE "font8x16c.asm" | ||
#ELSE | ||
#INCLUDE "font8x16u.asm" | ||
#ENDIF | ||
MEMECHO " 8X16" | ||
#ENDIF | ||
; | ||
#IFDEF USEFONTCGA | ||
FONTCGA: | ||
#IF USELZSA2 | ||
#INCLUDE "fontcgac.asm" | ||
#ELSE | ||
#INCLUDE "fontcgau.asm" | ||
#ENDIF | ||
MEMECHO " CGA" | ||
#ENDIF | ||
; | ||
#IFDEF USEFONTVGARC | ||
FONTVGARC: | ||
#IF USELZSA2 | ||
#INCLUDE "fontvgarcc.asm" | ||
#ELSE | ||
#INCLUDE "fontvgarcu.asm" | ||
#ENDIF | ||
MEMECHO " VGARC" | ||
#ENDIF | ||
; | ||
SIZ_FONTS .EQU $ - ORG_FONTS | ||
MEMECHO " occupy " | ||
MEMECHO SIZ_FONTS | ||
MEMECHO " bytes.\n" | ||
; | ||
HB_FONTS_END .EQU $ |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An opinion:
This command overwrites and replaces the logic (116-122) that creates osimg2.bin. This will probably break S100 functionality, It would be easier to understand if you included this line in the above if statement
I don't see any conditional IF FONTS_INLINE around this code, should there be?
The concept of building an oversize hbios.bin file which you then split-up using this command, is counter to the approach used in much of the build. i.e. Generally should build smaller BIN files specifically with the content you need and append these files together using binary copy. better to stick to this approach for clarity and consistency
I didn't see any changes to makefile to support this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kiwisincebirth,
I have been having an offline conversation with @b1ackmai1er about this. This conversation probably should have been as part of this PR or a discussion in the repository. Sorry about that.
I had already suggested to @b1ackmai1er that the imbedding of the fonts in the alternate ROM bank be done differently. Specifically, I am advocating that all fonts be imbedded and indexed by a simple table of font id's and pointers. This would allow the fonts to just another chunk within a ROM bank (like all the other .bin chunks).
Thanks, Wayne