Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(graphqlmetrics): dont store raw data for intermediate table, use NULL engine #1376

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

refactor(graphqlmetrics): dont store raw data for intermediate table, use NULL engine #1376

wants to merge 7 commits into from
+146 −119

Conversation

StarpTech
Copy link
Contributor

Motivation and Context

This will avoid that we unnecessarily store the raw data in ClickHouse. Materialized views will still work because they are trigger-based.

Checklist

  • I have discussed my proposed changes in an issue and have received approval to proceed.
  • I have followed the coding standards of the project.
  • Tests or benchmarks have been added or updated.
  • Documentation has been updated on https://github.com/wundergraph/cosmo-docs.
  • I have read the Contributors Guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noroth Noroth Noroth approved these changes

@jensneuse jensneuse Awaiting requested review from jensneuse

@Aenimus Aenimus Awaiting requested review from Aenimus

@df-wg df-wg Awaiting requested review from df-wg

Assignees
No one assigned
Labels
graphqlmetrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StarpTech @Noroth