-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(router): refactor complexity limits #1364
Merged
df-wg
merged 7 commits into
main
from
dave/eng-5663-refactor-improve-security-complexity-limits
Nov 15, 2024
Merged
fix(router): refactor complexity limits #1364
df-wg
merged 7 commits into
main
from
dave/eng-5663-refactor-improve-security-complexity-limits
Nov 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
df-wg
force-pushed
the
dave/eng-5663-refactor-improve-security-complexity-limits
branch
2 times, most recently
from
November 12, 2024 14:41
1fa616d
to
ee032c8
Compare
devsergiy
reviewed
Nov 12, 2024
jensneuse
requested changes
Nov 14, 2024
StarpTech
requested changes
Nov 14, 2024
df-wg
force-pushed
the
dave/eng-5663-refactor-improve-security-complexity-limits
branch
from
November 15, 2024 08:23
19ed9ee
to
46ceb0a
Compare
jensneuse
approved these changes
Nov 15, 2024
StarpTech
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
df-wg
deleted the
dave/eng-5663-refactor-improve-security-complexity-limits
branch
November 15, 2024 09:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Previous work (#1153) added in the opportunity to limit allowed query depth, rejecting a query if it passes the acceptable limit. This PR moves that configuration into a newly created security.complexity_limits
section, while still maintaining the now deprecated
security. depth_limit` section for the next 60 daysIt will now be configured using:
Checklist