Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix the audio enabled error #828

Merged
merged 5 commits into from
Apr 26, 2020
Merged

Attempt to fix the audio enabled error #828

merged 5 commits into from
Apr 26, 2020

Conversation

karaggeorge
Copy link
Member

Only thing I could see causing the audio to not enable if the permission is there, is the promise which fetches the audio devices failing for some reason. So I added some error handling around it to verify.

Also removed some old settings like DnD and Hide Desktop Icons which are now replaced by the plugins

@karaggeorge
Copy link
Member Author

@sindresorhus I've pushed some more updates fixing the audio devices error. I opened an issue at aperture-node: wulkano/aperture-node#10

But I figured until that can be investigated and fixed, we can use macos-audio-devices to get the same list

@sindresorhus
Copy link
Contributor

From https://github.com/karaggeorge/macos-audio-devices:

macOS 10.13 or earlier needs to download the Swift runtime support libraries.

This needs to be documented in the Kap readme now.

@karaggeorge
Copy link
Member Author

Do you think we should use the aperture one and only use the other one if it fails? It look like it only fails sometime. Not sure what's causing it but we could have it there in case it does. That way if you are running older than 10.13 you might at least have a chance to get the audio devices without the support libraries

@sindresorhus
Copy link
Contributor

Do you think we should use the aperture one and only use the other one if it fails? It look like it only fails sometime. Not sure what's causing it but we could have it there in case it does. That way if you are running older than 10.13 you might at least have a chance to get the audio devices without the support libraries

Yes, let's do that for now. Also add a comment that it will not be needed when we fix the Aperture issue.

@karaggeorge
Copy link
Member Author

@sindresorhus should be good 👍 I'll try to take a look at the Aperture issue during the week

@sindresorhus sindresorhus merged commit 647459b into master Apr 26, 2020
@sindresorhus sindresorhus deleted the enable-audio branch April 26, 2020 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants