Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement functionality for project card to dictate how to handle sco… #375

Open
wants to merge 3 commits into
base: selection-refactor
Choose a base branch
from
Open

Implement functionality for project card to dictate how to handle sco… #375

wants to merge 3 commits into from

Conversation

e-lo
Copy link
Collaborator

@e-lo e-lo commented Sep 9, 2024

Fixes #373 as described in that issue. Associated required issue: network-wrangler/projectcard#32

@e-lo e-lo added this to the v1.0 milestone Sep 9, 2024
@e-lo e-lo requested a review from yueshuaing September 9, 2024 18:13
@e-lo e-lo self-assigned this Sep 9, 2024
@e-lo
Copy link
Collaborator Author

e-lo commented Sep 9, 2024

@yueshuaing -

  • confirm this is the desired functionality
  • add a test to test desired functionality

@e-lo
Copy link
Collaborator Author

e-lo commented Sep 12, 2024 •
edited
Loading

TODO:

  • Add overwrite_conflicting bool arg to apply()

@e-lo
Copy link
Collaborator Author

e-lo commented Sep 12, 2024

@yueshuaing and @i-am-sijia please confirm this is implemented as desired

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yueshuaing yueshuaing Awaiting requested review from yueshuaing

@i-am-sijia i-am-sijia Awaiting requested review from i-am-sijia

Assignees

@e-lo e-lo

Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@e-lo