Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Role Modification for Sub-Org Admins in AppPortalRoleManagementListener #6342

Merged
merged 18 commits into from
Jun 20, 2024

Conversation

HasiniSama
Copy link
Contributor

@HasiniSama HasiniSama commented May 22, 2024

Purpose

Enable role modification for sub-org admins in the AppPortalRoleManagementListener.

Changes

  • Added isRoleModificationAllowedForTenant method to check if role modification is allowed for the admin by verifying if the tenant is an organization.
  • Updated preUpdateUserListOfRole method to use this check and handle exceptions appropriately.

Testing

  • Verified that role modifications are allowed for sub-org admins.
  • Ensured that exceptions were handled correctly and informative error messages were provided.

Related Issues

Checklist

  • e2e cypress tests locally verified.
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided.
  • Unit tests provided.
  • Integration tests provided.

Security checks

@CLAassistant
Copy link

CLAassistant commented May 22, 2024

CLA assistant check
All committers have signed the CLA.

@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@AnuradhaSK AnuradhaSK merged commit 9a89537 into wso2:master Jun 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants