Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hybrid flow response type application level configuration #6271

Merged
merged 15 commits into from
Jun 28, 2024
Merged

Add hybrid flow response type application level configuration #6271

merged 15 commits into from
Jun 28, 2024

Conversation

asha15
Copy link
Contributor

@asha15 asha15 commented May 16, 2024 •
edited
Loading

Purpose

$subject

An application level configuration will be introduced to enabled the hybrid flow. The developer can be able to select the allowed hybrid flow response type for the application.

Allowed response type check box will be pop up when hybrid flow is enabled.

Screenshot from 2024-06-07 08-30-52

Related Issues

Related PRs

Checklist

  • e2e cypress tests locally verified.
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

@pavinduLakshan
Copy link
Contributor

NEW chip seems to be misaligned, as per the screenshot. Let's fix that as well.

pavinduLakshan
pavinduLakshan reviewed May 16, 2024
View reviewed changes
.changeset/ten-walls-laugh.md Show resolved Hide resolved
features/admin.applications.v1/components/forms/inbound-oidc-form.tsx Outdated Show resolved Hide resolved
features/admin.applications.v1/components/forms/inbound-oidc-form.tsx Outdated Show resolved Hide resolved
features/admin.applications.v1/components/forms/inbound-oidc-form.tsx Outdated Show resolved Hide resolved
features/admin.applications.v1/components/forms/inbound-oidc-form.tsx Outdated Show resolved Hide resolved
features/admin.applications.v1/components/forms/inbound-oidc-form.tsx Outdated Show resolved Hide resolved
features/admin.applications.v1/components/forms/inbound-oidc-form.tsx Show resolved Hide resolved
features/admin.applications.v1/components/forms/inbound-oidc-form.tsx Outdated Show resolved Hide resolved
features/admin.applications.v1/components/forms/inbound-oidc-form.tsx Outdated Show resolved Hide resolved
features/admin.applications.v1/components/settings/access-configuration.tsx Outdated Show resolved Hide resolved
@asha15
Copy link
Contributor Author

asha15 commented May 17, 2024

NEW chip seems to be misaligned, as per the screenshot. Let's fix that as well.

sorry, this is how the 'new' chip will appear. Hope it's fine.

Screenshot from 2024-05-17 18-09-46

@pavinduLakshan
Copy link
Contributor

NEW chip seems to be misaligned, as per the screenshot. Let's fix that as well.

sorry, this is how the 'new' chip will appear. Hope it's fine.

Screenshot from 2024-05-17 18-09-46

The text "NEW" in the chip and the heading "Hybrid Flow" need to be horizontally aligned. Appreciate it if we could fix that as well.

@pavinduLakshan
Copy link
Contributor

NEW chip seems to be misaligned, as per the screenshot. Let's fix that as well.

Let's update the screenshot in the PR description.

@asha15
Copy link
Contributor Author

asha15 commented Jun 7, 2024

NEW chip seems to be misaligned, as per the screenshot. Let's fix that as well.

Let's update the screenshot in the PR description.

Updated.

pavinduLakshan
pavinduLakshan previously approved these changes Jun 14, 2024
View reviewed changes
@pavinduLakshan pavinduLakshan self-requested a review June 15, 2024 03:59
@pavinduLakshan pavinduLakshan dismissed their stale review June 15, 2024 04:02

let's merge this once the migration tasks are completed

brionmario
brionmario previously approved these changes Jun 25, 2024
View reviewed changes
features/admin.applications.v1/components/forms/inbound-oidc-form.tsx
@@ -503,6 +525,13 @@ export const InboundOIDCForm: FunctionComponent<InboundOIDCFormPropsInterface> =

}, [ selectedGrantTypes, isGrantChanged ]);

useEffect(() => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the useEffects above the functions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have followed the same approach for other useEffects, shall we keep this as it is?

features/admin.applications.v1/components/forms/inbound-oidc-form.tsx Outdated Show resolved Hide resolved
@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@asha15 asha15 merged commit a8bda06 into wso2:master Jun 28, 2024
6 checks passed
@wso2-jenkins-bot wso2-jenkins-bot mentioned this pull request Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Achintha444 Achintha444 Achintha444 approved these changes

@pavinduLakshan pavinduLakshan Awaiting requested review from pavinduLakshan

@brionmario brionmario Awaiting requested review from brionmario

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@asha15 @pavinduLakshan @wso2-jenkins-bot @brionmario @Achintha444