[improvement] Move session refresh logic to Application level #6135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
brionmario
reviewed
May 2, 2024
| @@ -73,7 +73,7 @@ export class AuthenticateUtils { | |||
| responseMode: window["AppUtils"]?.getConfig()?.idpConfigs?.responseMode ?? responseModeFallback, | |||
| scope: window["AppUtils"]?.getConfig()?.idpConfigs?.scope ?? [ TokenConstants.SYSTEM_SCOPE ], | |||
| sendCookiesInRequests: true, | |||
| sessionRefreshInterval: window[ "AppUtils" ]?.getConfig()?.session?.sessionRefreshTimeOut, | |||
| sessionRefreshInterval: -1, | |||
There was a problem hiding this comment.
This is to disable the session refresh from SDK. We can't pass undefined as SDK has a fallback value defined.
There was a problem hiding this comment.
There should be an option in the SDK to disable session refresh interval right?
Shall we create an issue in the SDK for this and move forward with the workaround for the timebeing.
There was a problem hiding this comment.
Created an issue: asgardeo/asgardeo-auth-react-sdk#226
brionmario
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Session refresh logic is moved to the Console application level. And disabled from the SDK. Improvement is done to avoid sending session refresh calls when the user is inactive.
Related Issues
Related PRs
Checklist
Security checks