Branding custom texts : Add support to preview multiple variations of the same screen #6027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RushanNanayakkara
force-pushed
the
ft_branding_page_variants
branch
2 times, most recently
from
69aa82b
to
11b2786
Compare
RushanNanayakkara
force-pushed
the
ft_branding_page_variants
branch
from
11b2786
to
eae2b55
Compare
…variants # Conflicts: # modules/i18n/src/models/namespaces/branding-ns.ts # modules/i18n/src/translations/en-US/portals/branding.ts
features/admin.branding.v1/components/screen-variation-dropdown.tsx
Outdated
Show resolved
Hide resolved
features/admin.branding.v1/components/screen-variation-dropdown.tsx
Outdated
Show resolved
Hide resolved
features/admin.branding.v1/context/branding-preference-context.tsx
Outdated
Show resolved
Hide resolved
|
PR builder started |
|
PR builder completed |
…variants # Conflicts: # apps/console/scripts/populate-branding-i18n-defaults.js
pavinduLakshan
previously approved these changes
May 8, 2024
…variants # Conflicts: # features/admin.branding.v1/constants/custom-text-preference-constants.ts
…randing_page_variants # Conflicts: # features/admin.branding.v1/components/branding-preference-tabs.tsx # features/admin.branding.v1/components/preview/sign-in-box/sign-in-box.tsx # features/admin.branding.v1/constants/custom-text-preference-constants.ts # features/admin.branding.v1/context/branding-preference-context.tsx # features/admin.branding.v1/models/custom-text-preference.ts # features/admin.branding.v1/providers/branding-preference-provider.tsx
RushanNanayakkara
added
trigger-pr-builder
RushanNanayakkara
force-pushed
the
ft_branding_page_variants
branch
from
eb84537
to
3412baf
Compare
RushanNanayakkara
force-pushed
the
ft_branding_page_variants
branch
3 times, most recently
from
f6ff745
to
11c49a9
Compare
RushanNanayakkara
force-pushed
the
ft_branding_page_variants
branch
from
11c49a9
to
156a656
Compare
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
pavinduLakshan
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The branding feature currently supports text customisation for selected screens. However, when the screen is dynamic and has multiple variations, it's not possible to preview these multiple variations of the screen.
SMS OTP for password recoveryfeature requires the multi screen support for branding.This PR adds the functionality to preview variations for the selected screen through the preview panel.
Related Issues
Related PRs
Checklist
Security checks
Screen recording
Screen.Recording.2024-04-23.at.14.07.25.mov