Changed the [Object][object] error that showed when a HyperlinkButton… #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is bound to an object
| VerticalAlignment="{TemplateBinding VerticalContentAlignment}"> | ||
| <TextBlock.Foreground> | ||
|
|
||
| <Border x:Name="UnderlineTextBlock" Margin="2,0,2,1" BorderThickness="0,0,0,1" Visibility="Collapsed"> |
There was a problem hiding this comment.
I'm concerned that this will negatively affect the underline on regular text. Should we show/hide the underline text box based on whether the bound data is text?
There was a problem hiding this comment.
The more I think about it...we should just apply TextDecorations = Underline should be applied to the content presenter on hover. Since TextDecorations is inheritable, it should cascade to the TextBlock in the template regardless of how it was created.
There was a problem hiding this comment.
I can try it and see what happens - the offshore team has already asked about the underline that shows up. This way, it can be controlled by template. I like this better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...is bound to an object