Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add virtual schedule page for Portland 2025 #2336

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Add virtual schedule page for Portland 2025 #2336

merged 1 commit into from
Mar 19, 2025

Conversation

mxsasha
Copy link
Contributor

@mxsasha mxsasha commented Mar 12, 2025 •
edited by github-actions bot
Loading

@mxsasha mxsasha force-pushed the pdx25-virtual-schedule branch 3 times, most recently from 563e745 to e67b7d5 Compare March 12, 2025 16:38
@mxsasha mxsasha requested a review from a team March 12, 2025 16:43
@plaindocs
Copy link
Contributor

This is kinda hard to preview, don't suppose you want to base it off #2334 instead?

@mxsasha
Copy link
Contributor Author

mxsasha commented Mar 14, 2025

This is kinda hard to preview, don't suppose you want to base it off #2334 instead?

I suppose we can just wait for that merge, there's no rush

@mxsasha mxsasha force-pushed the pdx25-virtual-schedule branch from e67b7d5 to ce02939 Compare March 19, 2025 15:50
@plaindocs
Copy link
Contributor

Is this just for including in Venueless? ie, we're not linking it from the main site?

@mxsasha
Copy link
Contributor Author

mxsasha commented Mar 19, 2025

Is this just for including in Venueless? ie, we're not linking it from the main site?

Yes, as an iframe embed.

@mxsasha mxsasha force-pushed the pdx25-virtual-schedule branch from ce02939 to f3f15b4 Compare March 19, 2025 16:51
plaindocs
plaindocs approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@plaindocs plaindocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case seems fine. I've not checked the schedule in anger.

@mxsasha mxsasha merged commit 0b046ee into main Mar 19, 2025
7 checks passed
@mxsasha mxsasha deleted the pdx25-virtual-schedule branch March 19, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plaindocs plaindocs plaindocs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxsasha @plaindocs