Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce UV to replace Pipenv; multi-stage Dockerfile (new PR) #624

Open
wants to merge 33 commits into
base: develop
Choose a base branch
from

Conversation

dmannarino
Copy link
Member

@dmannarino dmannarino commented Jan 29, 2025

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Using pipenv

Issue Number: N/A

What is the new behavior?

Pipenv replaced with uv

Does this introduce a breaking change?

  • Yes
  • No

Other information

@dmannarino dmannarino changed the base branch from master to develop January 29, 2025 04:01
@dmannarino dmannarino marked this pull request as ready for review January 29, 2025 04:03
@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 43 lines in your changes missing coverage. Please review.

Project coverage is 79.35%. Comparing base (8af1960) to head (bfbcf83).

Files with missing lines Patch % Lines
app/settings/gunicorn_conf.py 0.00% 43 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #624      +/-   ##
===========================================
- Coverage    79.91%   79.35%   -0.56%     
===========================================
  Files          133      134       +1     
  Lines         6129     6172      +43     
===========================================
  Hits          4898     4898              
- Misses        1231     1274      +43     
Flag Coverage Δ
unittests 79.35% <0.00%> (-0.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmannarino dmannarino marked this pull request as draft January 29, 2025 16:21
@dmannarino dmannarino marked this pull request as ready for review January 29, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants