Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake Fix RCON Microphysics #2162

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

islas
Copy link
Collaborator

@islas islas commented Jan 27, 2025

TYPE: bug fix

KEYWORDS: cmake, compilation

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
PR #2144 added a new microphysics file phys/module_mp_rcon.F which only added it to the make build

Solution:
Add new RCON file to CMake build

TESTS CONDUCTED:

  1. Develop branch at merge of RCON Microphysics #2144 fails to build CMake build. These changes fix the build issues

@islas islas requested a review from a team as a code owner January 27, 2025 23:16
@weiwangncar
Copy link
Collaborator

The Jenkins test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@islas islas merged commit a0144bd into wrf-model:develop Jan 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants