Make servo class use composition instead of PWM inheritance #7814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

ThadHouse opened this issue Feb 22, 2025 · 0 comments · Fixed by #7845

Assignees

Labels

2027 component: wpilibc component: wpilibj

Member

ThadHouse commented Feb 22, 2025

The inheritance makes things confusing to users, as it shows methods that cause the HAL to crash.

ThadHouse added the 2027 label

auscompgeek added component: wpilibj component: wpilibc labels

PeterJohnson added this to 2027

PeterJohnson assigned ThadHouse

PeterJohnson linked a pull request

that will close this issue

[hal, wpilib] PWM Rewrite #7845

Merged

PeterJohnson closed this as completed

github-project-automation bot moved this to Done in 2027

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment