Improve support for CPT and CTT by bredecl · Pull Request #61 · wpbones/WPBones

bredecl · 2025-03-20T21:03:53Z

Hi
I made some improvements for the bones cli and content

Added support to ask yes or no and returns a string to be used directly in stubs
Better code for CPT, so now generates automatically the default name, plural, slug based on name
Added a function to avoid create a post_type name larger than 20 characters (as described here: https://developer.wordpress.org/reference/functions/register_post_type/ )
Added support to set showInRest and showUI directly supports in CPT
Added a default icon for the stub of CPT, so we avoid the empty space
fix to avoid loop the menu -> items when is empty
Added support to show an example on ask method
Added support to pre-fill the data on CTT
Allow multiple Post Type support to CTT
Added support to set showui by default on CTT
Added support to manage CPT trash event.

…ctly in stubs - Better code for CPT, so now generates automatically the default name, plural, slug based on name - Added a function to avoid create a post_type name larger than 20 characters (as described here: https://developer.wordpress.org/reference/functions/register_post_type/ ) - Added support to set showInRest and showUI directly supports in CPT - Added a default icon for the stub of CPT, so we avoid the empty space

- Added support to pre-fill the data on CTT - Allow multiple Post Type support to CTT - Added support to set showui by default on CTT

gfazioli · 2025-03-21T08:18:39Z

@bredecl hey, thank you for the PR 🙏 - where is your previous PR about the database?

bredecl · 2025-03-21T14:35:34Z

@gfazioli I deleted it, it wasn't working as I expected, but I will work it again in it.

- explanation of CTT fix

WIP: Add support for WPBONES_TEXTDOMAIN - Added a Menu Relations to self generated menus from CTT - Added support to make use of WPBONES_TEXTDOMAIN on Admin Menu Provider Important, this could lead to a break on your code, you *need* to add at least ``` defined("WPBONES_TEXTDOMAIN","your_text_domain"); ``` in `config.php` or update your code based on wpbones/WPKirk#32

bredecl · 2025-03-25T21:07:07Z

@gfazioli hi!
I was wondering, why we should use an own database class instead of illuminate/database?
Is there any scope about the package size?
I manage to solve partially the relations (WIP), but still think the illuminate/database is the best approach (so we don't need to do again something that already exists).

I look forward to your feedback

fix closes the askYesNo method

gfazioli · 2025-04-02T09:19:03Z

@gfazioli hi! I was wondering, why we should use an own database class instead of illuminate/database? Is there any scope about the package size? I manage to solve partially the relations (WIP), but still think the illuminate/database is the best approach (so we don't need to do again something that already exists).

I look forward to your feedback

Yes, illuminate/database is definitely better. However, I chose to leave it out as a separate package to install because the issue is that being in a WordPress environment, this can cause some problems:

Package size issue: not all users require complex database-level features. They can use the functions already provided by WordPress or utilize the lighter Bones part, which still allows for many of the basic operations that most plugin developers need
The latest version of illuminate/database requires PHP 8+ and some users have hosting and plugins that only work with PHP 7.4+ (All wp bones boilerplates require only PHP 7.4+)
Since illuminate/database is public and managed by Composer, no renaming is done on the namespace. Using Composer packages in a WordPress environment can cause issues. For example, if there are two plugins that both use illuminate/database, only one of these will be loaded and used

bredecl · 2025-04-03T18:50:07Z

hi @gfazioli
Perfect! I will work based on that, also to try to achieve better relationships between tables in WP Multisite.
Also, regarding the namespace renaming… wouldn't it be better to keep the wpbones namespace separate and allow the user to construct with their own plugin namespace?
I'm also thinking about working on a kind of Storage (based on WP Settings) to keep Laravel's methods like disk, put, sizes, and others.

gfazioli · 2025-04-04T07:12:28Z

@bredecl

Also, regarding the namespace renaming… wouldn't it be better to keep the wpbones namespace separate and allow the user to construct with their own plugin namespace?

What do you mean exactly?

gfazioli

@balazsnasz maybe you already know, but the namespace is not correct

gfazioli · 2025-03-21T06:38:16Z

src/Console/bin/bones

     * @param string|null $default The default value
     */
-    protected function ask(string $str, ?string $default = ''): string
+    protected function ask(string $str, ?string $default = '',?string $example = ''): string


add the new optional $example param in the function docs

@param string|null $example

gfazioli · 2025-03-21T06:39:46Z

src/Console/bin/bones

      return $line ?: $default;
    }
+    /**
+     * Get input from console


maybe the doc need updating

gfazioli · 2025-03-21T06:43:33Z

src/Console/bin/bones

        $this->line(' Created plugin/Console/Kernel.php');
      }
    }
+    protected function simplePluralize($word) {


gfazioli · 2025-03-21T06:45:40Z

src/Console/bin/bones

+        "Remember to add \\{$namespace}\CustomPostTypes\\{$className} in the config/plugin.php array in the 'custom_post_types' key."
      );
    }
+    private function stringToArray($content){


gfazioli · 2025-03-21T06:45:52Z

src/Console/bin/bones

+      }
+      return $itemsSupport;
+    }
+    private function slugify($namespace,$name,$remove=0){


gfazioli · 2025-03-21T06:50:58Z

src/Console/bin/bones

+        "Remember to add \\{$namespace}\CustomPostTypes\\{$className} in the config/plugin.php array in the 'custom_post_types' key."
      );
    }
+    private function stringToArray($content){


what do you think to use this version

private function stringToArray($content) { // Split the string by commas and trim whitespace from each item $items = array_map('trim', explode(",", $content)); // Filter out any empty items return array_filter($items, fn($item) => !empty($item)); }

gfazioli · 2025-03-21T08:23:45Z

src/Console/bin/bones

+      }
+      return $itemsSupport;
+    }
+    private function slugify($namespace,$name,$remove=0){


What exactly is the purpose of this function?

balazsnasz · 2025-06-11T09:28:44Z

@balazsnasz maybe you already know, but the namespace is not correct

@gfazioli are you sure you wanted to tag me? @bredecl was working on this issue and I have no clue about this issue

gfazioli · 2025-06-11T15:01:41Z

@balazsnasz maybe you already know, but the namespace is not correct

@gfazioli are you sure you wanted to tag me? @bredecl was working on this issue and I have no clue about this issue

yep, sorry, I wanted tag @bredecl 🙏

bredecl added 4 commits March 20, 2025 15:26

fix to avoid loop the menu -> items when is empty

a6ba2fd

- Added support to show an example on ask method

ed6a8e0

- Added support to pre-fill the data on CTT - Allow multiple Post Type support to CTT - Added support to set showui by default on CTT

Added support to manage CPT trash event.

ac55a86

bredecl mentioned this pull request Mar 20, 2025

updated info for CPT page wpbones/website-docs#8

Merged

bredecl added 6 commits March 24, 2025 20:47

add support for columns on Custom Taxonomy Type

e47f394

- fix to use the ClassName in ucfirst as filename

5e6dc10

- explanation of CTT fix

add try/catch in case of missing classes on src/Foundation/Plugin.php

927e08f

fix on stringToArray to remove empty spaces

f84eef6

added missing auto menu generator

43d710f

bredecl added 2 commits April 1, 2025 14:58

Merge branch 'master' into master

ce84d62

Update bones

b8ae22a

fix closes the askYesNo method

bredecl added 3 commits June 9, 2025 20:24

respaldo

4df1c4d

Merge branches 'master' and 'master' of github.com:bredecl/WPBones

8bcd29a

respaldo

794b8e6

gfazioli requested changes Jun 10, 2025

View reviewed changes

gfazioli marked this pull request as draft June 24, 2025 06:37

Uh oh!

Conversation

bredecl commented Mar 20, 2025

Uh oh!

gfazioli commented Mar 21, 2025

Uh oh!

bredecl commented Mar 21, 2025

Uh oh!

bredecl commented Mar 25, 2025

Uh oh!

gfazioli commented Apr 2, 2025

Uh oh!

bredecl commented Apr 3, 2025

Uh oh!

gfazioli commented Apr 4, 2025

Uh oh!

gfazioli left a comment

Choose a reason for hiding this comment

Uh oh!

gfazioli Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

gfazioli Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

gfazioli Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

gfazioli Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

gfazioli Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

gfazioli Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

gfazioli Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

balazsnasz commented Jun 11, 2025

Uh oh!

gfazioli commented Jun 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants