Add authentication events #998
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LauraBeatris
force-pushed
the
add-authentication-email-verification-events
branch
from
59676c0
to
5f34b3e
Compare
LauraBeatris
commented
Mar 25, 2024
src/user-management/interfaces/authentication-events.interface.ts
Outdated
Show resolved
Hide resolved
LauraBeatris
commented
Mar 25, 2024
src/user-management/interfaces/authentication-events.interface.ts
Outdated
Show resolved
Hide resolved
LauraBeatris
changed the title
EmailVerification entity
LauraBeatris
requested review from
amygdalama
and removed request for
oliverzheng
amygdalama
reviewed
Mar 25, 2024
src/user-management/interfaces/authentication-events.interface.ts
Outdated
Show resolved
Hide resolved
LauraBeatris
changed the title
LauraBeatris
commented
Mar 25, 2024
src/user-management/interfaces/authentication-event.interface.ts
Outdated
Show resolved
Hide resolved
LauraBeatris
force-pushed
the
add-authentication-email-verification-events
branch
from
a04be2d
to
39fdd37
Compare
|
@amygdalama Types updated! I'll proceed with testing locally. |
amygdalama
reviewed
Mar 26, 2024
src/user-management/interfaces/authentication-event.interface.ts
Outdated
Show resolved
Hide resolved
amygdalama
reviewed
Mar 26, 2024
|
|
||
| export type AuthenticationEvent = { | ||
| type: AuthenticationEventType; | ||
| email?: string | null; |
There was a problem hiding this comment.
Suggested change
| email?: string | null; | |
| email: string | null; |
amygdalama
reviewed
Mar 26, 2024
|
|
||
| export interface AuthenticationEventResponse { | ||
| type: AuthenticationEventType; | ||
| email?: string | null; |
There was a problem hiding this comment.
Suggested change
| email?: string | null; | |
| email: string | null; |
There was a problem hiding this comment.
Seems like we're not that consistent with nullable properties, there are a couple of other places that use undefined | null.
I've updated error to | null as well: b972c1d
LauraBeatris
force-pushed
the
add-authentication-email-verification-events
branch
from
20a8dab
to
ef843cd
Compare
|
We'll hold on merging this since not all events are being emitted internally yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding types/parsing for authentication events.
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.