More stuff

workleap · Dec 10, 2024 · 637a668 · 637a668
1 parent 91b1729
commit 637a668
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 8 deletions.
diff --git a/package.json b/package.json
@@ -8,8 +8,8 @@
     "scripts": {
         "dev-pkg": "turbo dev --filter=./packages/*",
         "dev-basic": "turbo dev --filter=./samples/basic/*",
-        "dev-basic-webpack": "turbo dev-webpack --filter=./samples/basic-webpack/*",
-        "dev-basic-mix": "turbo dev-webpack --filter=./samples/basic-mix/*",
+        "dev-basic-webpack": "turbo dev --filter=./samples/basic-webpack/*",
+        "dev-basic-mix": "turbo dev --filter=./samples/basic-mix/*",
         "dev-endpoints": "turbo dev --filter=./samples/endpoints/*",
         "dev-docs": "retype start",
         "build-pkg": "turbo run build --filter=./packages/*",

diff --git a/packages/firefly-rsbuild-configs/src/defineConfig.ts b/packages/firefly-rsbuild-configs/src/defineConfig.ts
@@ -137,9 +137,20 @@ function getEnvironmentVariablesSharedDependencies(isHost: boolean): ModuleFeder
     };
 }
 
-// TODO: Should add "@opentelemetry/api"
 function getHoneycombSharedDependencies(isHost: boolean): ModuleFederationShared {
     return {
+        "@honeycombio/opentelemetry-web": {
+            singleton: true,
+            eager: isHost ? true : undefined
+        },
+        "@opentelemetry/api": {
+            singleton: true,
+            eager: isHost ? true : undefined
+        },
+        "@opentelemetry/auto-instrumentations-web": {
+            singleton: true,
+            eager: isHost ? true : undefined
+        },
         "@squide/firefly-honeycomb": {
             singleton: true,
             eager: isHost ? true : undefined

diff --git a/packages/firefly-webpack-configs/src/defineConfig.ts b/packages/firefly-webpack-configs/src/defineConfig.ts
@@ -119,6 +119,18 @@ function getEnvironmentVariablesSharedDependencies(isHost: boolean): ModuleFeder
 
 function getHoneycombSharedDependencies(isHost: boolean): ModuleFederationShared {
     return {
+        "@honeycombio/opentelemetry-web": {
+            singleton: true,
+            eager: isHost ? true : undefined
+        },
+        "@opentelemetry/api": {
+            singleton: true,
+            eager: isHost ? true : undefined
+        },
+        "@opentelemetry/auto-instrumentations-web": {
+            singleton: true,
+            eager: isHost ? true : undefined
+        },
         "@squide/firefly-honeycomb": {
             singleton: true,
             eager: isHost ? true : undefined

diff --git a/turbo.json b/turbo.json
@@ -4,11 +4,6 @@
     "ui": "tui",
     "tasks": {
         "dev": {
-            "dependsOn": ["@squide/firefly-rsbuild-configs#build"],
-            "cache": false,
-            "persistent": true
-        },
-        "dev-webpack": {
             "dependsOn": ["@squide/firefly-rsbuild-configs#build", "@squide/firefly-webpack-configs#build"],
             "cache": false,
             "persistent": true