Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper text to action menu #636

Merged
merged 8 commits into from
Jan 10, 2024
Merged

Add helper text to action menu #636

merged 8 commits into from
Jan 10, 2024

Conversation

kevinp-uzi
Copy link
Contributor

Added ability to add helper text in an action menu. Contents of helper text are passed to dropdown footer.

Copy link

changeset-bot bot commented Jan 10, 2024

🦋 Changeset detected

Latest commit: d3341c5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@igloo-ui/action-menu Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Jan 10, 2024

Deploy Preview for igloo-ui ready!

Name Link
🔨 Latest commit d3341c5
🔍 Latest deploy log https://app.netlify.com/sites/igloo-ui/deploys/659ef61bd884140008fbc28e
😎 Deploy Preview https://deploy-preview-636--igloo-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

vicky-comeau
vicky-comeau previously approved these changes Jan 10, 2024
alexasselin008

This comment was marked as duplicate.

fraincs
fraincs previously approved these changes Jan 10, 2024
Copy link
Member

@alexasselin008 alexasselin008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A Chromatic test should be added for this new feature in ActionMenu.stories.tsx

@kevinp-uzi kevinp-uzi dismissed stale reviews from fraincs and vicky-comeau via 249a8b5 January 10, 2024 19:46
@vicky-comeau
Copy link
Collaborator

Add "@igloo-ui/helper-text": "^0.2.16" to devDependencies in ActionMenu package.json and then do yarn install

vicky-comeau
vicky-comeau previously approved these changes Jan 10, 2024
@vicky-comeau vicky-comeau requested a review from fraincs January 10, 2024 20:06
@vicky-comeau vicky-comeau merged commit ed3dc67 into workleap:main Jan 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants