Skip to content

Commit

Permalink
Fix: [IGL-106] Input character count color fix and version updates
Browse files Browse the repository at this point in the history
  • Loading branch information
vicky-comeau committed Dec 19, 2023
1 parent 6b0da7b commit 4eb1f53
Show file tree
Hide file tree
Showing 54 changed files with 137 additions and 83 deletions.
51 changes: 51 additions & 0 deletions .changeset/clean-needles-taste.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
---
"@igloo-ui/action-menu": patch
"@igloo-ui/alert": patch
"@igloo-ui/area-chart": patch
"@igloo-ui/avatar": patch
"@igloo-ui/bar-chart": patch
"@igloo-ui/breadcrumb": patch
"@igloo-ui/button": patch
"@igloo-ui/button-group": patch
"@igloo-ui/card": patch
"@igloo-ui/carousel": patch
"@igloo-ui/checkbox": patch
"@igloo-ui/color": patch
"@igloo-ui/color-picker": patch
"@igloo-ui/combobox": patch
"@igloo-ui/datepicker": patch
"@igloo-ui/dialog": patch
"@igloo-ui/disclosure": patch
"@igloo-ui/dropdown": patch
"@igloo-ui/ellipsis": patch
"@igloo-ui/filter": patch
"@igloo-ui/form-group": patch
"@igloo-ui/helper-text": patch
"@igloo-ui/hyperlink": patch
"@igloo-ui/icon-button": patch
"@igloo-ui/input": patch
"@igloo-ui/list": patch
"@igloo-ui/metric": patch
"@igloo-ui/modal": patch
"@igloo-ui/option-button": patch
"@igloo-ui/pager": patch
"@igloo-ui/pie-chart": patch
"@igloo-ui/popover": patch
"@igloo-ui/progress-bar": patch
"@igloo-ui/radio": patch
"@igloo-ui/select": patch
"@igloo-ui/stacked-bar": patch
"@igloo-ui/stepper": patch
"@igloo-ui/tabs": patch
"@igloo-ui/tag": patch
"@igloo-ui/tag-picker": patch
"@igloo-ui/text-editor": patch
"@igloo-ui/textarea": patch
"@igloo-ui/toaster": patch
"@igloo-ui/toggle": patch
"@igloo-ui/tooltip": patch
"@igloo-ui/vertical-bar-chart": patch
"docs": patch
---

Updated input icon and character count colors. Also updated hopper token versions and igloo icon versions.
4 changes: 2 additions & 2 deletions packages/ActionMenu/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@
"@igloo-ui/tokens": "^2.0.0",
"@igloo-ui/dropdown": "^1.6.4",
"@igloo-ui/list": "^0.5.2",
"@hopper-ui/tokens": "^3.1.1",
"@hopper-ui/tokens": "^3.1.2",
"classnames": "^2.3.2"
},
"devDependencies": {
"@igloo-ui/icons": "^1.11.0",
"@igloo-ui/icons": "^1.12.2",
"@igloo-ui/button": "^0.7.3",
"@igloo-ui/icon-button": "^1.1.5"
},
Expand Down
4 changes: 2 additions & 2 deletions packages/Alert/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@
"dependencies": {
"@igloo-ui/button": "^0.7.3",
"@igloo-ui/icon-button": "^1.1.5",
"@igloo-ui/icons": "^1.11.0",
"@igloo-ui/icons": "^1.12.2",
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.1",
"@hopper-ui/tokens": "^3.1.2",
"classnames": "^2.3.2"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/AreaChart/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.1",
"@hopper-ui/tokens": "^3.1.2",
"classnames": "^2.3.2",
"luxon": "^3.2.1",
"recharts": "^2.9.2"
Expand Down
2 changes: 1 addition & 1 deletion packages/Avatar/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.1",
"@hopper-ui/tokens": "^3.1.2",
"classnames": "^2.3.2"
},
"browserslist": [
Expand Down
2 changes: 1 addition & 1 deletion packages/BarChart/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.1",
"@hopper-ui/tokens": "^3.1.2",
"classnames": "^2.3.2",
"framer-motion": "^6.5.1"
},
Expand Down
4 changes: 2 additions & 2 deletions packages/Breadcrumb/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@
},
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.1",
"@hopper-ui/tokens": "^3.1.2",
"classnames": "^2.3.2",
"@igloo-ui/icons": "^1.11.0"
"@igloo-ui/icons": "^1.12.2"
},
"browserslist": [
"> 1%",
Expand Down
4 changes: 2 additions & 2 deletions packages/Button/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@
},
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.1",
"@hopper-ui/tokens": "^3.1.2",
"classnames": "^2.3.2"
},
"devDependencies": {
"@igloo-ui/icons": "^1.11.0"
"@igloo-ui/icons": "^1.12.2"
},
"browserslist": [
"> 1%",
Expand Down
4 changes: 2 additions & 2 deletions packages/ButtonGroup/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.1",
"@hopper-ui/tokens": "^3.1.2",
"classnames": "^2.3.2"
},
"browserslist": [
Expand All @@ -34,7 +34,7 @@
"IE >= 11"
],
"devDependencies": {
"@igloo-ui/icons": "^1.11.0",
"@igloo-ui/icons": "^1.12.2",
"@igloo-ui/tooltip": "^3.4.2"
}
}
2 changes: 1 addition & 1 deletion packages/Card/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.1",
"@hopper-ui/tokens": "^3.1.2",
"classnames": "^2.3.2"
},
"browserslist": [
Expand Down
2 changes: 1 addition & 1 deletion packages/Carousel/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.1",
"@hopper-ui/tokens": "^3.1.2",
"classnames": "^2.3.2"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/Checkbox/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.1",
"@hopper-ui/tokens": "^3.1.2",
"classnames": "^2.3.2"
},
"browserslist": [
Expand Down
2 changes: 1 addition & 1 deletion packages/Color/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.1",
"@hopper-ui/tokens": "^3.1.2",
"classnames": "^2.3.2"
},
"browserslist": [
Expand Down
2 changes: 1 addition & 1 deletion packages/ColorPicker/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"@igloo-ui/color": "^0.3.1",
"@igloo-ui/dropdown": "^1.6.4",
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.1",
"@hopper-ui/tokens": "^3.1.2",
"classnames": "^2.3.2",
"react-aria": "^3.30.0",
"react-aria-components": "^1.0.0-rc.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/Combobox/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@
"dependencies": {
"@igloo-ui/dropdown": "^1.6.4",
"@igloo-ui/list": "^0.5.2",
"@igloo-ui/icons": "^1.11.0",
"@igloo-ui/icons": "^1.12.2",
"@igloo-ui/icon-button": "^1.1.5",
"@igloo-ui/input": "^2.1.6",
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.1",
"@hopper-ui/tokens": "^3.1.2",
"@igloo-ui/tooltip": "^3.4.2",
"classnames": "^2.3.2"
},
Expand Down
4 changes: 2 additions & 2 deletions packages/Datepicker/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@
"@igloo-ui/button": "^0.7.3",
"@igloo-ui/dropdown": "^1.6.4",
"@igloo-ui/icon-button": "^1.1.5",
"@igloo-ui/icons": "^1.11.0",
"@igloo-ui/icons": "^1.12.2",
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.1",
"@hopper-ui/tokens": "^3.1.2",
"@internationalized/date": "^3.5.0",
"classnames": "^2.3.2",
"luxon": "^3.4.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/Dialog/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"classnames": "^2.3.2",
"@igloo-ui/modal": "*",
"@igloo-ui/button": "*",
"@hopper-ui/tokens": "^3.1.1"
"@hopper-ui/tokens": "^3.1.2"
},
"browserslist": [
"> 1%",
Expand Down
2 changes: 1 addition & 1 deletion packages/Disclosure/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.1",
"@hopper-ui/tokens": "^3.1.2",
"classnames": "^2.3.2",
"framer-motion": "^6.5.1",
"react-aria": "^3.30.0",
Expand Down
4 changes: 4 additions & 0 deletions packages/Disclosure/src/disclosure.scss
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,10 @@

.ids-disclosure .ids-disclosure__header-icon {
margin: var(--ids-disclosure-header-icon-margin);

& svg {
display: block;
}
}

.ids-disclosure--low-contrast .ids-disclosure__header-icon {
Expand Down
2 changes: 1 addition & 1 deletion packages/Dropdown/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"dependencies": {
"@floating-ui/react": "^0.24.8",
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.1",
"@hopper-ui/tokens": "^3.1.2",
"classnames": "^2.3.2"
},
"browserslist": [
Expand Down
2 changes: 1 addition & 1 deletion packages/Ellipsis/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.1",
"@hopper-ui/tokens": "^3.1.2",
"classnames": "^2.3.2"
},
"browserslist": [
Expand Down
2 changes: 1 addition & 1 deletion packages/Filter/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.1",
"@hopper-ui/tokens": "^3.1.2",
"classnames": "^2.3.2"
},
"browserslist": [
Expand Down
4 changes: 2 additions & 2 deletions packages/FormGroup/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
},
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@igloo-ui/icons": "^1.11.0",
"@hopper-ui/tokens": "^3.1.1",
"@igloo-ui/icons": "^1.12.2",
"@hopper-ui/tokens": "^3.1.2",
"classnames": "^2.3.2",
"@igloo-ui/helper-text": "^0.2.15"
},
Expand Down
4 changes: 2 additions & 2 deletions packages/HelperText/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@
"build": "rollup -c rollup.config.js"
},
"dependencies": {
"@igloo-ui/icons": "^1.11.0",
"@igloo-ui/icons": "^1.12.2",
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.1",
"@hopper-ui/tokens": "^3.1.2",
"classnames": "^2.3.2"
},
"browserslist": [
Expand Down
2 changes: 1 addition & 1 deletion packages/Hyperlink/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
},
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.1",
"@hopper-ui/tokens": "^3.1.2",
"@react-aria/link": "^3.6.2",
"classnames": "^2.3.2"
},
Expand Down
4 changes: 2 additions & 2 deletions packages/IconButton/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@
"dependencies": {
"@igloo-ui/button": "^0.7.3",
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.1",
"@hopper-ui/tokens": "^3.1.2",
"classnames": "^2.3.2"
},
"devDependencies": {
"@igloo-ui/icons": "^1.11.0"
"@igloo-ui/icons": "^1.12.2"
},
"browserslist": [
"> 1%",
Expand Down
4 changes: 2 additions & 2 deletions packages/Input/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@
},
"dependencies": {
"@igloo-ui/tokens": "^2.0.0",
"@hopper-ui/tokens": "^3.1.1",
"@hopper-ui/tokens": "^3.1.2",
"classnames": "^2.3.2",
"graphemer": "^1.4.0"
},
"devDependencies": {
"@igloo-ui/icons": "^1.11.0"
"@igloo-ui/icons": "^1.12.2"
},
"browserslist": [
"> 1%",
Expand Down
9 changes: 4 additions & 5 deletions packages/Input/src/input.scss
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@
--ids-input-letter-spacing-compact: #{tokens.$font-weight-regular};

/* with icon */
--ids-input-color-icon: #{tokens.$grey-400};
--ids-input-color-icon-compact: #{tokens.$grey-800};
--ids-input-color-icon: #{tokens.$grey-500};

/* with prefix icon */
--ids-input-width-prefix: #{tokens.$space-7};
Expand All @@ -45,6 +44,7 @@
--ids-input-min-width-character-indicator: #{tokens.$space-4};
--ids-input-width-character-indicator-suffix: #{tokens.$space-9};
--ids-input-width-character-indicator-suffix-compact: #{tokens.$space-8};
--ids-input-character-indicator-color: #{tokens.$grey-400};

/* Placeholder */
--ids-input-color-placeholder: #{tokens.$grey-400};
Expand Down Expand Up @@ -87,7 +87,6 @@

/* with icon */
--ids-input-color-icon: var(--hop-neutral-icon-weak);
--ids-input-color-icon-compact: var(--hop-neutral-icon-weak);

/* with prefix icon */
--ids-input-width-prefix: 2.5rem;
Expand Down Expand Up @@ -125,6 +124,7 @@
--ids-input-min-width-character-indicator: 2rem;
--ids-input-width-character-indicator-suffix: 6rem;
--ids-input-width-character-indicator-suffix-compact: 5rem;
--ids-input-character-indicator-color: var(--hop-neutral-text-weakest);
}

%ids-input-asset {
Expand Down Expand Up @@ -196,6 +196,7 @@
}

.ids-input__char-indicator {
color: var(--ids-input-character-indicator-color);
font-size: var(--ids-input-font-size-character-indicator);
min-width: var(--ids-input-min-width-character-indicator);
padding: var(--ids-input-padding-character-indicator);
Expand All @@ -219,12 +220,10 @@
}

.ids-input__asset--prefix--compact {
color: var(--ids-input-color-icon-compact);
width: var(--ids-input-width-prefix-compact);
}

.ids-input__asset--suffix--compact {
color: var(--ids-input-color-icon-compact);
width: var(--ids-input-width-suffix-compact);
}

Expand Down
Loading

0 comments on commit 4eb1f53

Please sign in to comment.