Remove GitHub Action workflow to run Danger on PRs #14378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plan was to use this stack instead of Peril on Heroku, but we bumped into a few too many integration issues. I'll be keeping an eye on Danger and revisit the feasibility of the project periodically. I have no doubt that as Danger evolves, we'll be able to adopt it without the tradeoffs we would have had to made at this point in time.
|
You can trigger an installable build for these changes by visiting CircleCI here. |
Generated by 🚫 dangerJS |
This was referenced Jun 24, 2020
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
loremattei
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plan was to use this stack instead of Peril on Heroku, but we bumped into a few too many integration issues.
I'll be keeping an eye on Danger and revisit the feasibility of the project periodically. I have no doubt that as Danger evolves, we'll be able to adopt it without the tradeoffs we would have had to made at this point in time.
More detail on the original issue for the migration work.
To test, it should be enough to see that only Peril is posting comments on this PR and that no GitHub Action run as part of it.Update, we did get a comment from Danger here... 🤔 That's because on
develop, the main branch for this repo, we still have the workflow and it listens to themilestonedevent, which I triggered by adding the milestone here.I'd say, then, that the only way to test this PR is to merge it, and then make sure Danger won't have run on PRs opened afterwards.
PR submission checklist:
RELEASE-NOTES.txtif necessary.