design: 날짜/시간 문구 형식 변경 #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimhm0728
commented
Jan 29, 2025
Comment on lines
+25
to
+31
| fun Int.toDurationTimeMessage(): String { | ||
| val hour = this / 60 | ||
| val minute = this % 60 | ||
| val localTime = LocalTime.of(hour, minute) | ||
| val pattern = if (hour == 0) MINUTE_PATTERN else HOUR_MINUTE_PATTERN | ||
| return localTime.format(pattern) | ||
| } |
There was a problem hiding this comment.
도착지까지 30분 걸려요같은 메시지의 경우 "오전", "오후"가 표시되면 안되기 때문에 따로 구현했습니다!!
이 함수는 추후 다시 사용될 여지가 충분할 것 같아 util 함수로 분리했어요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚩 연관 이슈
close #962
📝 작업 내용
🏞️ 스크린샷 (선택)
🗣️ 리뷰 요구사항 (선택)
저번 회의(해음 없었을 때 ㅠ) 때 결정한 날짜/시간 형식을 모든 화면에 통일시켰습니다!
현재는 notification localDateTime만 형식이 달라서, 그건 util 함수로 빼지 않고 notification 관련 로직으로 두었어요
추가적으로 routeTime -> durationTime 네이밍 변경도 했습니다