Python 3.12 support: PEP-709 (inlined comprehension) #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wookayin
force-pushed
the
py312
branch
10 times, most recently
from
7956829 to
1de0760
Compare
This comment was marked as resolved.
This comment was marked as resolved.
The previous code raised an error when parsing list/set/dict
comprehensions; "IndexError: pop from empty list".
current_table = self._table_stack.pop() # <--- HERE
As per PEP-0709:
The symtable module will no longer produce child symbol tables for
comprehensions (but excluding generator expressions); instead, the
comprehension’s locals will be included in the parent function’s
symbol table and scope.
wookayin
changed the title
3 tasks
|
Some follow-ups need to be done but merging for now, to make semshi work in a minimal viable manner with python3.12. Remaining: remove the assumption on the implementation details about AST syntax tree (e.g. inline comprehension is not inlined at the moment, but if it's inlined in future CPython versions it will break again). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New syntax in python 3.12. Part of #20.