Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add godot linter to harmonitze toplevel comments #3650

Merged
merged 6 commits into from
May 13, 2024
Merged

Add godot linter to harmonitze toplevel comments #3650

merged 6 commits into from
May 13, 2024

Conversation

xoxys
Copy link
Member

@xoxys xoxys commented Apr 26, 2024

I would like to harmonize at least top level comments in the code. I have not yet applied any code changes, please review the settings and let me know which style you prefer.

@xoxys xoxys requested a review from a team April 26, 2024 07:48
@xoxys xoxys added the refactor delete or replace old code label Apr 26, 2024
@qwerty287
Copy link
Contributor

I'm fine with it.

@xoxys xoxys marked this pull request as draft April 30, 2024 13:11
@xoxys
Copy link
Member Author

xoxys commented Apr 30, 2024

@woodpecker-ci/maintainers Please add your opinions, otherwise Ill use the current config and apply the required changes.

@6543
Copy link
Member

6543 commented Apr 30, 2024

hmm even you told to ignore cSpell - the linter errors :/

@xoxys
Copy link
Member Author

xoxys commented Apr 30, 2024

For now that doesn't really matter IMO. Ill address this as soon as I start to work on the refactoring.

@xoxys
Copy link
Member Author

xoxys commented Apr 30, 2024

Fixed the exclude config just to proof it works. Pretty sure there will be more as soon as I start to work on it.

@xoxys xoxys marked this pull request as ready for review May 13, 2024 20:15
@xoxys xoxys requested review from a team and pat-s May 13, 2024 20:15
@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented May 13, 2024

Deployment of preview was torn down

@xoxys xoxys merged commit 89e100c into main May 13, 2024
5 of 7 checks passed
@xoxys xoxys deleted the lint-comment branch May 13, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor delete or replace old code skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants