Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.2 deprecations (2388) #1939

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Conversation

pedrosilva-pt
Copy link
Contributor

PR Description

Fixes "Using ${var} in strings is deprecated ..." deprecation notice in SmartButton class.
The source code was scanned for other instances of this deprecation, none was found.

Issue Description

PHP 8.2 deprecations

Relates to the Pay Later messaging render hooks:

"woocommerce_paypal_payments_${location_hook}_messages_renderer_hook",

Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /home/hotijitaxo0287/web/evil-elephant-ekli9.instawp.xyz/public_html/wp-content/plugins/woocommerce-paypal-payments/modules/ppcp-button/src/Assets/SmartButton.php on line 1441

Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /home/hotijitaxo0287/web/evil-elephant-ekli9.instawp.xyz/public_html/wp-content/plugins/woocommerce-paypal-payments/modules/ppcp-button/src/Assets/SmartButton.php on line 1442

Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /home/hotijitaxo0287/web/evil-elephant-ekli9.instawp.xyz/public_html/wp-content/plugins/woocommerce-paypal-payments/modules/ppcp-button/src/Assets/SmartButton.php on line 1457

Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /home/hotijitaxo0287/web/evil-elephant-ekli9.instawp.xyz/public_html/wp-content/plugins/woocommerce-paypal-payments/modules/ppcp-button/src/Assets/SmartButton.php on line 1457

Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /home/hotijitaxo0287/web/evil-elephant-ekli9.instawp.xyz/public_html/wp-content/plugins/woocommerce-paypal-payments/modules/ppcp-button/src/Assets/SmartButton.php on line 1578

Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /home/hotijitaxo0287/web/evil-elephant-ekli9.instawp.xyz/public_html/wp-content/plugins/woocommerce-paypal-payments/modules/ppcp-button/src/Assets/SmartButton.php on line 1585

Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /home/hotijitaxo0287/web/evil-elephant-ekli9.instawp.xyz/public_html/wp-content/plugins/woocommerce-paypal-payments/modules/ppcp-button/src/Assets/SmartButton.php on line 1609

Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /home/hotijitaxo0287/web/evil-elephant-ekli9.instawp.xyz/public_html/wp-content/plugins/woocommerce-paypal-payments/modules/ppcp-button/src/Assets/SmartButton.php on line 1616

@InpsydeNiklas InpsydeNiklas added this to the 2.5.0 milestone Jan 4, 2024
@Dinamiko Dinamiko merged commit 2a83209 into trunk Jan 5, 2024
14 checks passed
@Dinamiko Dinamiko deleted the PCP-2388-php-8-2-deprecations branch January 5, 2024 11:10
@Dinamiko Dinamiko added the enhancement New feature or request label Jan 12, 2024
@Dinamiko Dinamiko mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants