make all hosted card fields strings translatable (2488) #1926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrosilva-pt
requested review from
Dinamiko,
AlexP11223,
Narek13 and
mmaymo
AlexP11223
approved these changes
Dec 27, 2023
Dinamiko
deleted the
PCP-2488-make-all-hosted-card-fields-strings-translatable
branch
Merged
|
Any updates about how we style the new card fields? the CSS is not taking effect at all like before |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Card Fieldstexts are already translatable via WooCommerce native translations. https://github.com/woocommerce/woocommerce/blob/trunk/plugins/woocommerce/includes/gateways/class-wc-payment-gateway-cc.php#L60-L74placeholdersof theCard Fieldsto be translated theplaceholderJavascript configuration attribute needs to be passed to each field.Card Numberfieldplaceholderisn't translatable, this PR also adds the possibility of translating it, and applies thewoocommerce_paypal_payments_card_fields_translate_card_numberfilter in case we want to disable this translation.Issue Description
Currently, only the Cardholder Name field can be translated with WordPress translation files.
The Card number, Expiry, and CVV fields currently are provided by the PayPal SDK but they should also be translatable with WordPress translation files.