GooglePay and ApplePay buttons disappear from the minicart when adding a product to the cart on the shop page (PCP-2472) #1915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrosilva-pt
requested review from
Dinamiko,
AlexP11223,
Narek13 and
mmaymo
pedrosilva-pt
changed the title
Dinamiko
approved these changes
Dec 19, 2023
Dinamiko
deleted the
PCP-2472-google-pay-and-apple-pay-buttons-disappear-when-adding-a-product-to-the-cart-on-the-shop-page
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR handles rerendering of
ApplePayandGooglePaybuttons onwc_fragments_loaded wc_fragments_refreshedevent.Issue Description
When adding a product to the Minicart on the shop page the GooglePay and ApplePay buttons disappear.
Before adding to cart:
After adding to cart:
Steps To Reproduce
Expected behaviour
After adding a product to cart on the shop page the minicart still has the GooglePay and ApplePay buttons visible.
Possible cause
This is probably due to the minicart dom element being rerendered and but the GooglePay and ApplePay buttons not handling this event.
Suggested solution
GooglePay and ApplePay buttons should handle the Minicart rerendering event.