Block Checkout reloads when submitting order with empty fields (2389) #1904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrosilva-pt
requested review from
Dinamiko,
AlexP11223,
Narek13 and
mmaymo
AlexP11223
reviewed
Dec 14, 2023
| @@ -152,6 +153,7 @@ const PayPalComponent = ({ | |||
| if (config.finalReviewEnabled) { | |||
| location.href = getCheckoutRedirectUrl(); | |||
| } else { | |||
| setGotoContinuation(true); | |||
There was a problem hiding this comment.
Maybe a better name could be something like gotoContinuationOnError or submittingWithoutReview.
Right now it looks a bit confusing because normally submitting in the no-review mode should not result in continuation.
Dinamiko
approved these changes
Dec 14, 2023
pedrosilva-pt
changed the title
InpsydeNiklas
deleted the
PCP-2389-block-checkout-reloads-when-submitting-order-with-empty-fields
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
To prevent the checkout page from reloading the
gotoContinuationstatus variable was added. It's dynamically set only on scenarios where we want to redirect.Issue Description
When submitting a payment on the Block Checkout page while some fields are empty, the field error messages will only briefly appear as the page reloads
Steps To Reproduce
Expected behaviour
page does not reload when WC validation failed