Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Send checkout billing and shipping data to Apple Pay" displayed when Apple Pay is disabled (2386) #1883

Conversation

pedrosilva-pt
Copy link
Contributor

PR Description

Added applepay_checkout_data_mode to the applepay_button_enabled rules.

Issue Description

The in 2.4.2 introduced setting Send checkout billing and shipping data to Apple Pay is visible even when Apple Pay is not enabled:

Steps To Reproduce

  • Navigate to Standard Payments tab
  • Disable Apple Pay
  • Observe setting is visible

Expected behaviour

Setting is not shown when Apple Pay is disabled.

@InpsydeNiklas InpsydeNiklas added this to the 2.5.0 milestone Dec 5, 2023
@Dinamiko Dinamiko merged commit dae59f3 into trunk Dec 13, 2023
14 checks passed
@Dinamiko Dinamiko deleted the PCP-2386-send-checkout-billing-and-shipping-data-to-apple-pay-displayed-when-apple-pay-is-disabled branch December 13, 2023 15:53
@Dinamiko Dinamiko mentioned this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants