Add imports that required once frameworks become modules #15698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
When moving from frameworks to Swift packages, see for example #15622 and #15651, we lose the framework headers which had statements like `#import <Foundation/Foundation.h>`. This means that basic frameworks such as Foundation and UIKit are no longer imported as part of consumers frameworks such as Yosemite. To simplify the code review of the upcoming PRs migrating those frameworks to Swift packages in `Modules/`, this PR preemptively adds the required imports in the files that need them. This was done by running `git reset trunk` on the workbench branch `temp-branch-for-swiftpm-migration` and only committing the `import` additions in this branch.
mokagio
force-pushed
the
mokagio/add-required-imports
branch
from
0a010be to
29e012c
Compare
mokagio
changed the base branch from
ainfra-471-move-experiments-to-modules
to
trunk
mokagio
added
the
category: tooling
|
|
AliSoftware
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When moving from frameworks to Swift packages, see for example #15622 and #15651, we lose the framework headers which had statements like
#import <Foundation/Foundation.h>. This means that basic frameworks such asFoundation and UIKit are no longer imported as part of consumers frameworks such as Yosemite. To simplify the code review of the upcoming PRs migrating those frameworks to Swift packages in
Modules/, this PR preemptively adds the required imports in the files that need them.This was done by running
git reset trunkon the workbench branchtemp-branch-for-swiftpm-migrationand only committing theimportadditions in this branch.Closes https://linear.app/a8c/issue/AINFRA-673
Steps to reproduce
Testing information
Screenshots
RELEASE-NOTES.txtif necessary.