-
Notifications
You must be signed in to change notification settings - Fork 116
Shipping Label: Handle payment method selection #15684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
itsmeichigo
merged 8 commits into
trunk
from
woomob-527-payment-integrate-api-endpoint-to-save-account-settings
Jun 3, 2025
Merged
Shipping Label: Handle payment method selection #15684
itsmeichigo
merged 8 commits into
trunk
from
woomob-527-payment-integrate-api-endpoint-to-save-account-settings
Jun 3, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
…-existing' into woomob-527-payment-integrate-api-endpoint-to-save-account-settings
RafaelKayumov
approved these changes
Jun 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested on iPhone 16 (18.4) Simulator
Base automatically changed from
woomob-434-payment-update-the-payment-method-sheet-with-existing
to
trunk
June 3, 2025 10:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature: shipping labels
Related to creating, ordering, or printing shipping labels.
type: task
An internally driven task.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes WOOMOB-527
Description
This PR integrates the account setting update API endpoint to handle payment method selection. Changes include:
WooShippingRemote
with a new method for updating account settings.WooShippingAction
and WooShippingStore`.Testing steps
Testing information
Tested and confirmed with simulator iPhone 16 iOS 18.4
Screenshots
Simulator.Screen.Recording.-.iPhone.16.-.2025-05-30.at.17.50.02.mp4
Error state:
RELEASE-NOTES.txt
if necessary.