-
Notifications
You must be signed in to change notification settings - Fork 117
Shipping Labels: Show existing payment methods for selection #15679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shipping Labels: Show existing payment methods for selection #15679
Conversation
|
HStack(alignment: .top) { | ||
Image(systemName: "info.circle") | ||
Text(String(format: Localization.note, viewModel.storeOwnerUsername)) | ||
.frame(maxWidth: .infinity, alignment: .leading) | ||
} | ||
.font(.footnote) | ||
.foregroundStyle(Color.primary) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This view is inconsistent in the design. I'm using the style used in both the design for existing payment methods and the one for shop managers.
…d-sheet-with-existing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested - works as described. Left a couple of questions.
Another question. Tested the edge case with many payment methods. In case if the selected method has a distant position in a long list, it won't be visible right after presenting the bottom sheet. Should we address that and always show the selected method on top of the list despite its original position? Or may me scroll to the selected method on pre-selection?
Simulator.Screen.Recording.-.iPhone.16.-.2025-06-03.at.13.00.03.mp4
@@ -18,13 +19,41 @@ struct WooShippingPaymentMethodsView: View { | |||
paymentMethodList | |||
} | |||
|
|||
HStack(alignment: .top) { | |||
Image(systemName: "info.circle") | |||
Text(String(format: Localization.note, viewModel.storeOwnerUsername)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This view is inconsistent in the design. I'm using the style used in both the design for existing payment methods and the one for shop managers.
Were you mentioning the inconsistency in note appearance between empty / non empty states in designs?
NIT: The note in the design contains a user first name + last name and the @
username wrapped in angle brackets.

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were you mentioning the inconsistency in note appearance between empty / non empty states in designs?
Yes, I mean details like the (i) icon and the text color. I decided to use unify the styles for simplicity.
NIT: The note in the design contains a user first name + last name and the @ username wrapped in angle brackets.
NIT: the note and padding look a bit different for empty state comparing to design:
I'll update these as part of #15705
Good idea. I added the sorting for the list in #15705. Since this PR is the base of 2 other PRs, I'll merge this for now. |
Closes WOOMOB-434
Description
This PR adds UI updates to show existing payment methods for a store in the shipping label purchase flow. Button actions will be handle in subsequent PRs.
Testing steps
Testing information
Tested and confirmed using simulator iPhone 16 iOS 18.4 in light & dark modes with different font sizes. Both portrait and landscape modes look good.
Screenshots
RELEASE-NOTES.txt
if necessary.