This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Update the checkout order endpoint allowed order statuses for payment complete #12018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.61 MB ℹ️ View Unchanged
|
senadir
reviewed
Dec 4, 2023
| @@ -100,7 +100,7 @@ protected function get_route_post_response( \WP_REST_Request $request ) { | |||
| $order_id = absint( $request['id'] ); | |||
| $this->order = wc_get_order( $order_id ); | |||
|
|
|||
| if ( $this->order->get_status() !== 'pending' && $this->order->get_status() !== 'failed' ) { | |||
| if ( ! $this->order->needs_payment() ) { | |||
There was a problem hiding this comment.
This is a much better check yeah.
malithsen
approved these changes
Dec 4, 2023
hsingyuc
requested review from
a team and
senadir
and removed request for
a team
senadir
approved these changes
Dec 7, 2023
hsingyuc
force-pushed
the
fix/order-status-requirement-for-the-checkout-order-endpoint
branch
from
97747a5 to
7fd4a2b
Compare
hsingyuc
deleted the
fix/order-status-requirement-for-the-checkout-order-endpoint
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The checkout order endpoint requires that the order status is either
failedorpendingso we can pay for the order. For plugin compatibility, we should allow custom order status, for example,scheduledfrom WooCommerce Deposits.Fixes https://github.com/Automattic/woopay/issues/2374
Why
complete,processing,refunded,etc., then we show the error, but we might miss other plugin's statuses.woocommerce_valid_order_statuses_for_payment_completefilter, butneeds_paymentincludes the filter, so it's a better approach.Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Test
scheduled,failed,pending, etc order statuses.trueoncheck_noncescheduledorders, and copy theCustomer payment pagelinkCustomer payment pageto go to the pay-for-order pagekeyfrom the URLhttp://merchant.local/wp-json/wc/store/checkout/YOUR_ORDER_NUMBER?key=YOUR_KEY&billing_email=YOUR_BILLING_EMAILNo AuthPending paymentand Customer:Existing customerkeyandbilling_emailparams and send the requestScreenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog