This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Remove Approved Pull Requests Workflow
#12017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielwrobert
added
the
skip-changelog
woocommercebot
requested review from
a team and
thealexandrelara
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.61 MB ℹ️ View Unchanged
|
danielwrobert
changed the title
ADD_LABEL Step for 'status: ready to merge' LabelApproved Pull Requests Workflow
This updates the workflow to remove the step for adding the 'status: ready to merge' label. Additionally, this adjusts the naming within the job to reflect the change to the workflow.
Once Woo Blocks is merged into the monorepo, this workflow will no longer be needed / relevant at all.
danielwrobert
force-pushed
the
update/approved-with-labels-action
branch
from
d62988f to
e21bb65
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This removes the
Approved Pull Requestsworkflow, which adds the 'status: ready to merge' label, removes thestatus: needs reviewlabel, and adds the PR to the latest milestone.These jobs will no longer be relevant once this repository is moved into the monorepo.
Fixes #
Why
See internal conversation for context: pdToLP-ZC-p2#comment-745
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Note: this can only be tested once it has been merged, since it pertains to a PR workflow action.
status: ready to mergelabel is created/added.status: needs reviewlabel, if present.Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog