This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Move shopper-side Checkout E2E tests to Playwright #11998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarhi-saad
added
tools
woocommercebot
requested review from
a team and
wavvves
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.61 MB ℹ️ View Unchanged
|
wavvves
approved these changes
Dec 7, 2023
nielslange
reviewed
Dec 7, 2023
There was a problem hiding this comment.
Thanks for migrating these tests, @tarhi-saad. However, I noticed that the line breaks between different sections seem to be missing in the migrated test file (tests/e2e/tests/checkout/checkout-block.shopper.block_theme.side_effects.spec.ts, lines 109-315). This file currently has only 2 line breaks in the 206 lines, impacting its readability. Could you share the reasoning behind this approach? Adding appropriate line breaks can enhance the clarity and maintainability of the code.
tarhi-saad
force-pushed
the
update/convert-checkout-shopping-e2e-tests
branch
from
026bc53 to
595fc2e
Compare
|
I added some line breaks as suggested, @nielslange! 🙌 |
nielslange
reviewed
Dec 8, 2023
There was a problem hiding this comment.
Thanks for applying the changes, @tarhi-saad. I left one more suggestion. 😀
tests/e2e/tests/checkout/checkout-block.shopper.block_theme.side_effects.spec.ts
Outdated
Show resolved
Hide resolved
nielslange
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Thanks for working on this, @tarhi-saad. The changes look great. Let's ⛴️ this! 🙌
This test detected a bug. We will skip it for now and create a ticket to fix it!
…de_effects.spec.ts Co-authored-by: Niels Lange <[email protected]>
tarhi-saad
force-pushed
the
update/convert-checkout-shopping-e2e-tests
branch
from
10c0ade to
74f2c24
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Moves shopper-side Checkout E2E tests to Playwright - we skipped them in Puppeteer to get old E2Es working again.
Removes the old Puppeteer shopper checkout tests.
Fixes #11895
Why
To 1) re-enable a skipped test and 2) move from Puppeteer to Playwright
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
block_themeandclassic_themeScreenshots or screencast
N/A
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog