Skip to content

Conversation

@PooruTorie
Copy link

@PooruTorie PooruTorie commented Sep 4, 2025

All Submissions:

  • Does your code follow the WooCommerce Sniffs variant of WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Will this change require new documentation or changes to existing documentation?

Changes proposed in this Pull Request:

Overide the get_time_interval_in_minutes function because the original one always returned 1 minute with the unit of night
This was breaking the callender intersection detection

Closes https://linear.app/a8c/issue/WOOACBK-58/tracking-issue-add-get-time-interval-in-minutes

Steps to test the changes in this Pull Request:

  1. Have a product with restricted booking days for only one day
  2. Book it for one week
  3. Try to book the next week

Changelog entry

Add - Overide the get_time_interval_in_minutes function for WC_Product_Accommodation_Booking

@vikrampm1 vikrampm1 requested a review from dkotter September 10, 2025 11:42
@vikrampm1 vikrampm1 added this to the Future Release milestone Sep 10, 2025
@qasumitbagthariya
Copy link
Collaborator

qasumitbagthariya commented Nov 6, 2025

Update:
Unable to test this PR due to a fatal error occurring during the testing process. The error appears to be coming from the Accommodation Bookings plugin.

I’ve already created a separate issue to track and address this error. Once it’s resolved, I’ll proceed with testing this PR again.

cc @ankitguptaindia @vikrampm1

@iamdharmesh
Copy link
Collaborator

Thanks for the PR, @PooruTorie. Could you please provide more details about the issue this PR fixes, along with steps to reproduce it? Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants