Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for sub menu description #1943

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Add support for sub menu description #1943

wants to merge 2 commits into from

Conversation

nielslange
Copy link
Member

Fixes #1595

This PR is an extension of #1771 and adds support for the submenu description. @gigitux mentioned this specific problem in #1771 (comment).

In this PR, I simply enhanced the SCSS styles to style the descriptions of both the menu and the submenu items similar.

Screenshots

Before:

#1595-before

 After:

#1595-after

How to test the changes in this Pull Request:

  1. Go to /wp-admin/nav-menus.php.
  2. Click on screen options in the upper-right corner and activate the option Description within Show advanced menu properties.
  3. Create a custom menu and assign it to the menu location Secondary Menu.
  4. Add 2-3 menu items with a description.

Changelog

Add support for submenu description.

@nielslange nielslange requested a review from a team as a code owner April 4, 2022 10:02
@gigitux gigitux mentioned this pull request Apr 4, 2022
Open
tjcafferkey
tjcafferkey previously approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@tjcafferkey tjcafferkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nielslange this looks much better! LGTM 🚢

@github-actions github-actions bot added the status: ready to merge Automatically applied to a pull when a pull is approved. Indicates ready for merging. label Apr 4, 2022
@gigitux
Copy link
Contributor

gigitux commented Apr 4, 2022

Related to this PR, there are still some works to do. For more context, check #1771.
@tjcafferkey Can you de-approved the PR? In this way, we are sure that anyone will not merge this PR.

@tjcafferkey tjcafferkey dismissed their stale review April 4, 2022 15:01

De-approving

@tjcafferkey tjcafferkey added status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. and removed status: ready to merge Automatically applied to a pull when a pull is approved. Indicates ready for merging. labels Apr 4, 2022
@github-actions github-actions bot added the status: ready to merge Automatically applied to a pull when a pull is approved. Indicates ready for merging. label Apr 5, 2022
@gigitux gigitux removed the status: ready to merge Automatically applied to a pull when a pull is approved. Indicates ready for merging. label Apr 6, 2022
@gigitux
Copy link
Contributor

gigitux commented Apr 6, 2022

@Procorners For this PR there are still some works to do. For more context, check #1771

@github-actions github-actions bot added the status: ready to merge Automatically applied to a pull when a pull is approved. Indicates ready for merging. label Apr 9, 2022
@tomasztunik tomasztunik removed the status: ready to merge Automatically applied to a pull when a pull is approved. Indicates ready for merging. label Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Procorners Procorners Procorners approved these changes

@tjcafferkey tjcafferkey tjcafferkey left review comments

@tomasztunik tomasztunik Awaiting requested review from tomasztunik

@gigitux gigitux Awaiting requested review from gigitux

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
status: blocked The issue is blocked from progressing, waiting for another piece of work to be done.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for menu description.
5 participants
@nielslange @gigitux @tjcafferkey @Procorners @tomasztunik