Fix Hero animation when drag-dismissing WoltModalSheet at zero threshold #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor drag handling logic for vertical and horizontal dismissals - Add minimum value check to prevent unintended dismissals - Use pattern matching for vertical drag direction - Ensure consistent animation controller value updates
|
@TahaTesser Do you think you may have time to check this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where Hero widgets fail to animate properly when drag-dismissing a WoltModalSheet that reaches a near-zero position. Previously, when dragging the sheet to a position very close to zero and releasing, the Hero widgets on the underlying route would not animate back correctly, while they worked fine when drag-dismissing from halfway or using fling gestures.
The fix prevents the animation controller from reaching a fully dismissed state during drag operations by implementing a minimum threshold of 0.01. This ensures the proper dismissal sequence is always followed, allowing Hero widgets to complete their transitions correctly.
Changes:
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process.
///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?