Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename LICENCE to LICENSE #32

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Rename LICENCE to LICENSE #32

merged 1 commit into from
Jun 19, 2024

Conversation

davidparsson
Copy link
Contributor

@davidparsson davidparsson commented Feb 16, 2023 •
edited
Loading

Fixes a spelling error in the filename.

@dogukancagatay dogukancagatay mentioned this pull request Jun 12, 2024
Closed
3 tasks
@dogukancagatay
Copy link

dogukancagatay commented Jun 12, 2024 •
edited
Loading

This one should have renamed the file at {{cookiecutter.project_slug}}/LICENCE. I think that is the one being used on the template.

@davidparsson
Copy link
Contributor Author

This one should have renamed the file at {{cookiecutter.project_slug}}/LICENCE. I think that is the one being used on the template.

You're right, thanks. I've fixed this now.

@dogukancagatay
Copy link

Related poetry docs say that the file with the LICENSE spelling is included automatically in the packaged artifacts.

https://github.com/python-poetry/poetry/blob/d144eb8fc6a3d9ab6535fe13d5d99ef2a4992368/docs/libraries.md?plain=1#L57

jerry-git
jerry-git approved these changes Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@jerry-git jerry-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍬 Thank you!

@jerry-git jerry-git merged commit 485c2ce into woltapp:master Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerry-git jerry-git jerry-git approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidparsson @dogukancagatay @jerry-git