Fix MinGW build #914
Closed
Fix MinGW build #914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
There is nothing formalized for that. |
Contributor
Author
Alright, will see if I can find more time to test this properly, should probably not be merged until it is tested properly by someone. |
Contributor
|
This PR doesn't work for me 100%. The |
Merged
Owner
|
Fixed by #1078 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wolfpld: Just made changes to fix the build for now, should probably not be merged until it is tested properly - is there a standard procedure for that already?
Feel like the
__except1macro control flow also needs to be checked, seems a bit iffy.