Skip to content

Conversation

@slomp
Copy link
Contributor

@slomp slomp commented Oct 9, 2024

The manual mentions 65534 unique source locations:

\item There can be no more than 65534 unique source locations\footnote{A source location is a place in the code, which is identified by source file name and line number, for example, when you markup a zone.}. This number is further split in half between native code source locations and dynamic source locations (for example, when Lua instrumentation is used).

So it looks like the current assert is wrong:

assert( m_data.sourceLocationExpand.size() < std::numeric_limits<int16_t>::max() );

and should be:

assert( m_data.sourceLocationExpand.size() < std::numeric_limits<uint16_t>::max() );

@slomp
Copy link
Contributor Author

slomp commented Oct 10, 2024

Ah, sorry, just realized about the split between static and dynamic. My bad.

@slomp slomp closed this Oct 10, 2024
@slomp slomp deleted the slomp/srcloc-max branch August 2, 2025 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant