Use DER-specified hash algorithm for PEM decryption #8452
Closed
+160
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Can one of the admins verify this patch? |
- Add support for both WOLFSSL_ASN_TEMPLATE and original ASN implementations - Use GetSequence and GetAlgoId for original ASN mode - Use template functions for WOLFSSL_ASN_TEMPLATE mode - Add proper error handling and messages Co-Authored-By: [email protected] <[email protected]>
devin-ai-integration
bot
force-pushed
the
devin/1739556249-pem-hash-algorithm
branch
from
5fce419 to
1c08ea4
Compare
- Extract hash type from PBES2 parameters in both ASN implementations - Add proper error handling and messages - Return ASN_PARSE_E if hash type cannot be determined - Fix variable declarations and scoping issues Co-Authored-By: [email protected] <[email protected]>
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies PemToDer to extract and use the hash algorithm from PBES2 parameters in the DER buffer instead of using hardcoded MD5.
The change:
Link to Devin run: https://app.devin.ai/sessions/634dd7963a224df584eeba810bc6f885
Requested by: [email protected]