Use atomics for write-dup mailbox state - #11005
Open
be0hhh wants to merge 1 commit into
Open
Conversation
|
Can one of the admins verify this patch? |
Member
|
Hi @be0hhh , thank you for the code contribution. Can you tell us more about your project and interest in our library? To be an external contributor we require a signed agreement. If you are willing to do this please email support at wolfssl dot com and include your physical location and details about your project/interests and a link the your active PR(s). |
Author
|
Thank you, David. Best regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use wolfSSL's portable atomic integer operations for the simple TLS write-dup error and KeyUpdate mailbox state when atomic operations are available.
The mutex remains responsible for lifetime and reference-count state. Configurations with DTLS 1.3 or post-handshake authentication retain the existing mutex mailbox path because they carry additional compound state and ownership.
This removes the explicit per-write mailbox mutex on the supported atomic path without changing the public API or the mailbox's level-triggered semantics.
Testing
master.ThreadSanitizer builds successfully after demoting its existing
atomic_thread_fencewarning, but its runtime exits before test execution in this WSL environment withunexpected memory mapping.Checklist