fix(advisory): per-product component in CDX VEX - #9
Open
MarkAtwood wants to merge 1 commit into
Open
Conversation
The CycloneDX VEX emitter collapsed every non-FIPS product onto the hardcoded wolfssl metadata.component, so a wolfSSH (or wolfMQTT, wolfTPM, ...) CVE emitted a VEX whose affects[] pointed at a component named "wolfssl" -- disagreeing with the CSAF output for the same record and mis-attributing the vulnerability. Mint a per-product component keyed on cdx_key (as the FIPS path already does) with the product's own name/cpe/purl, and reference it in affects[]; wolfssl products still use the umbrella metadata.component. Adds a regression test class covering a wolfSSH record.
There was a problem hiding this comment.
Pull request overview
This PR fixes CycloneDX 1.6 VEX generation so vulnerabilities for non-wolfSSL products (e.g., wolfSSH/wolfMQTT/wolfTPM) are attributed to a per-product component instead of being incorrectly collapsed onto the wolfssl metadata component, aligning product attribution with expected semantics.
Changes:
- Update
generate_cdx_vex()to mint a per-product CycloneDX component (keyed bycdx_key) for any non-FIPS, non-wolfsslproduct and pointvulnerabilities[].affects[]at that component. - Preserve
metadata.componentas thewolfsslumbrella component. - Add a regression unit test ensuring non-wolfSSL products get their own component and are referenced from
affects.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| central/gen-advisory | Emit per-product CycloneDX components for non-wolfssl products and reference them from VEX affects. |
| central/test_gen_advisory.py | Add regression coverage to prevent non-wolfSSL product attribution from collapsing onto metadata.component. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CycloneDX VEX collapsed every non-FIPS product onto the hardcoded
wolfsslmetadata.component, so a wolfSSH/wolfMQTT/wolfTPM CVE was attributed towolfssl(disagreeing with the CSAF output). Mints a per-product component keyed oncdx_keywith its own name/cpe/purl; wolfssl keeps the umbrella component. AddsTestCdxVexNonWolfsslProduct.